[webkit-reviews] review granted: [Bug 197002] [GTK] Support transient zoom : [Attachment 431424] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at gnome.org> has granted Alexander Mikhaylenko
<alexm at gnome.org>'s request for review:
Bug 197002: [GTK] Support transient zoom
https://bugs.webkit.org/show_bug.cgi?id=197002

Attachment 431424: Patch

https://bugs.webkit.org/attachment.cgi?id=431424&action=review




--- Comment #29 from Michael Catanzaro <mcatanzaro at gnome.org> ---
Comment on attachment 431424
  --> https://bugs.webkit.org/attachment.cgi?id=431424
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431424&action=review

> Source/WebKit/UIProcess/ViewGestureController.h:488
> +    static constexpr double minMagnification { 1 };
> +    static constexpr double maxMagnification { 3 };

I think const will suffice here. You probably don't need the constexpr?

> Source/WebKit/UIProcess/mac/ViewGestureControllerMac.mm:-54
> -static const double minMagnification = 1;
> -static const double maxMagnification = 3;

OK, EWS is sad. Looks like resistanceForDelta would need to become a static
class function, since it uses these but no longer has access to them.