[webkit-reviews] review granted: [Bug 226996] [JSC] Workaround ICU uloc_addLikelySubtags / uloc_minimizeSubtags bugs : [Attachment 431384] Patch

[bugzilla-daemon at webkit.org]

Ross Kirsling <ross.kirsling at sony.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 226996: [JSC] Workaround ICU uloc_addLikelySubtags / uloc_minimizeSubtags
bugs
https://bugs.webkit.org/show_bug.cgi?id=226996

Attachment 431384: Patch

https://bugs.webkit.org/attachment.cgi?id=431384&action=review




--- Comment #3 from Ross Kirsling <ross.kirsling at sony.com> ---
Comment on attachment 431384
  --> https://bugs.webkit.org/attachment.cgi?id=431384
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431384&action=review

All of our ICU workaround code honestly makes me want to cry, but r=me. ��

> Source/JavaScriptCore/ChangeLog:18
> +	   This is workaround, and still this workaround is not complete since
we could have many variants. In that case, uloc_addLikelySubtags /
uloc_minimizeSubtags
> +	   still fails, and in that case, for now, we give up performing
uloc_addLikelySubtags / uloc_minimizeSubtags. Fixing this needs to be
> +	   done in ICU side.

We should create a JIRA ticket for this.

> JSTests/stress/intl-long-locale-id-maximize-minimize.js:6
> +    const __v_16 = new
Intl.Locale(`de-Latn-DE-u-cu-eur-em-default-hc-h23-ks-level1-lb-strict-lw-norma
l-ms-metric-nu-latn-rg-atzzzz-sd-atat1-ss-none-tz-atvie-va-posix`);

Let's use less cryptic variable names.