[webkit-reviews] review granted: [Bug 226995] [REGRESSION: r276616] Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._setupCodeMirror.getValue') : [Attachment 431379] Patch v1.0

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 226995: [REGRESSION: r276616] Uncaught Exception: TypeError: undefined is
not an object (evaluating 'this._setupCodeMirror.getValue')
https://bugs.webkit.org/show_bug.cgi?id=226995

Attachment 431379: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=431379&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 431379
  --> https://bugs.webkit.org/attachment.cgi?id=431379
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=431379&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:319
> +	   if (!this._setupCodeMirror)

NIT: I'd not have this be an early return just so that if more fields are added
in the future it makes the diff cleaner :)