[webkit-reviews] review granted: [Bug 226990] Remove Storage Access API quirk on live.com : [Attachment 431365] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 14:41:50 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 226990: Remove Storage Access API quirk on live.com
https://bugs.webkit.org/show_bug.cgi?id=226990

Attachment 431365: Patch

https://bugs.webkit.org/attachment.cgi?id=431365&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 431365
  --> https://bugs.webkit.org/attachment.cgi?id=431365
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431365&action=review

r=me

> Source/WebCore/page/Quirks.cpp:1055
>	   && (element.classNames().contains("glyph_signIn_circle")

Observation: It sure seems like there should be a predicate that lets us test
if one set contains any of another set...


More information about the webkit-reviews mailing list