[webkit-reviews] review granted: [Bug 226916] [CG] Create a sub-image when drawing an image only if the destination image will be enlarged, rotated or sheared : [Attachment 431303] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 226916: [CG] Create a sub-image when drawing an image only if the
destination image will be enlarged, rotated or sheared
https://bugs.webkit.org/show_bug.cgi?id=226916

Attachment 431303: Patch

https://bugs.webkit.org/attachment.cgi?id=431303&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 431303
  --> https://bugs.webkit.org/attachment.cgi?id=431303
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431303&action=review

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:230
> +static inline bool shouldUseSubimage(CGInterpolationQuality
interpolationQuality, const FloatRect& destRect, const FloatRect& srcRect,
const AffineTransform& transform)

This could be a lambda function.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:241
> +static inline RetainPtr<CGImageRef> getSubimage(CGImageRef image, const
FloatSize& imageSize, const FloatRect& subimageRect, const
ImagePaintingOptions& options)

This could be a lambda function.

> Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:259
> +static inline FloatSize imageLogicalSize(CGImageRef image, const
ImagePaintingOptions& options)

This could be a lambda function.