[webkit-reviews] review granted: [Bug 226937] Add Air opcode sub32/64(Reg, Imm, Reg) form for ARM64 and select this instruction in Air : [Attachment 431328] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted  review:
Bug 226937: Add Air opcode sub32/64(Reg, Imm, Reg) form for ARM64 and select
this instruction in Air
https://bugs.webkit.org/show_bug.cgi?id=226937

Attachment 431328: Patch

https://bugs.webkit.org/attachment.cgi?id=431328&action=review




--- Comment #10 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 431328
  --> https://bugs.webkit.org/attachment.cgi?id=431328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431328&action=review

Reinstating r+

>> Source/JavaScriptCore/b3/testb3_2.cpp:2095
>> +void testSubArgs32ZeroExtend(int a, int b)
> 
> I think we should adds tests for imm sub forms you added.

Yijia informed me we already test this in testSubArgImm pre-existing test