[webkit-reviews] review granted: [Bug 226846] [Monterey] Support building WebKit : [Attachment 431285] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 14 08:55:03 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 226846: [Monterey] Support building WebKit
https://bugs.webkit.org/show_bug.cgi?id=226846

Attachment 431285: Patch

https://bugs.webkit.org/attachment.cgi?id=431285&action=review




--- Comment #15 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 431285
  --> https://bugs.webkit.org/attachment.cgi?id=431285
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431285&action=review

> Source/WebCore/html/HTMLElement.cpp:1377
> +		   TextRecognitionLineElements lineElements {
lineOrDataDetector, Vector<Ref<HTMLDivElement>>() };

Can probably use:
TextRecognitionLineElements lineElements { lineOrDataDetector, { } };

> Source/WebCore/html/HTMLElement.cpp:1430
> +	       TextRecognitionLineElements lineElements { lineContainer,
Vector<Ref<HTMLDivElement>>() };

ditto.


More information about the webkit-reviews mailing list