[webkit-reviews] review granted: [Bug 226877] [css-grid] Consider container's writing mode to get grid item's margin : [Attachment 431183] Patch

[bugzilla-daemon at webkit.org]

Sergio Villar Senin <svillar at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 226877: [css-grid] Consider container's writing mode to get grid item's
margin
https://bugs.webkit.org/show_bug.cgi?id=226877

Attachment 431183: Patch

https://bugs.webkit.org/attachment.cgi?id=431183&action=review




--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 431183
  --> https://bugs.webkit.org/attachment.cgi?id=431183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431183&action=review

> Source/WebCore/rendering/RenderGrid.cpp:1590
>      LayoutUnit gridBorder = isRowAxis ? borderLogicalLeft() :
borderBefore();

I wonder whether we have to do the same with borders and/or position. But
that's just food for thought for another bug.