[webkit-reviews] review granted: [Bug 226955] Number pad button is missing its image when tapping on <input type=tel> in watchOS 8 : [Attachment 431263] Fix watchOS 7 build (2)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 12 14:07:39 PDT 2021
Darin Adler <darin at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 226955: Number pad button is missing its image when tapping on <input
type=tel> in watchOS 8
https://bugs.webkit.org/show_bug.cgi?id=226955
Attachment 431263: Fix watchOS 7 build (2)
https://bugs.webkit.org/attachment.cgi?id=431263&action=review
--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 431263
--> https://bugs.webkit.org/attachment.cgi?id=431263
Fix watchOS 7 build (2)
View in context: https://bugs.webkit.org/attachment.cgi?id=431263&action=review
> Source/WebKit/UIProcess/ios/forms/WKTextInputListViewController.mm:-67
> - UIImage *numberPadButtonIcon = [PUICResources
imageNamed:@"QuickboardAddPhoneNumber" inBundle:[NSBundle
bundleWithIdentifier:@"com.apple.PepperUICore"] shouldCache:YES];
So this is not needed on older builds with !HAVE(PUIC_BUTTON_TYPE_PILL)?
More information about the webkit-reviews
mailing list