[webkit-reviews] review granted: [Bug 226806] Add lock for static cursorMap in MemoryCursor : [Attachment 430942] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 19:36:29 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 226806: Add lock for static cursorMap in MemoryCursor
https://bugs.webkit.org/show_bug.cgi?id=226806

Attachment 430942: Patch

https://bugs.webkit.org/attachment.cgi?id=430942&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 430942
  --> https://bugs.webkit.org/attachment.cgi?id=430942
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430942&action=review

r=me with changes

> Source/WebCore/Modules/indexeddb/server/MemoryCursor.cpp:47
>      ASSERT(!cursorMap().contains(m_info.identifier()));

This needs to be after the lock.

> Source/WebCore/Modules/indexeddb/server/MemoryCursor.cpp:56
>      ASSERT(cursorMap().contains(m_info.identifier()));

ditto.


More information about the webkit-reviews mailing list