[webkit-reviews] review denied: [Bug 226946] Lazily compute SecurityOrigin::m_isPotentiallyTrustworthy for performance : [Attachment 431240] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 226946: Lazily compute SecurityOrigin::m_isPotentiallyTrustworthy for
performance
https://bugs.webkit.org/show_bug.cgi?id=226946

Attachment 431240: Patch

https://bugs.webkit.org/attachment.cgi?id=431240&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 431240
  --> https://bugs.webkit.org/attachment.cgi?id=431240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431240&action=review

> Source/WebCore/page/SecurityOrigin.cpp:496
> +    return m_isPotentiallyTrustworthy;

return *m_isPotentiallyTrustworthy;

> Source/WebCore/page/SecurityOrigin.h:246
> +    std::optional<bool> m_isPotentiallyTrustworthy;

This uses more memory.	To offset this, could you make some of the surrounding
booleans bit fields?