[webkit-reviews] review granted: [Bug 226832] Regression(r276653) We're going to disk more often for local storage operations : [Attachment 431149] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226832: Regression(r276653) We're going to disk more often for local
storage operations
https://bugs.webkit.org/show_bug.cgi?id=226832

Attachment 431149: Patch

https://bugs.webkit.org/attachment.cgi?id=431149&action=review




--- Comment #18 from Darin Adler <darin at apple.com> ---
Comment on attachment 431149
  --> https://bugs.webkit.org/attachment.cgi?id=431149
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431149&action=review

Geoff reviewed this, but it says review? so I am setting review+.

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:41
> +static constexpr ASCIILiteral getItemsQueryString { "SELECT key, value FROM
ItemTable"_s };

No need for static, no need for ASCIILiteral.

    constexpr auto getItemsQueryString { "SELECT key, value FROM ItemTable"_s
};

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:149
> +	   for (auto& entry : *m_items) {

For better performance, consider adding this?

    items.reserveInitialCapacity(m_items->size());