[webkit-reviews] review granted: [Bug 226930] Add fast-path for binding security check of DOMWindow : [Attachment 431211] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 226930: Add fast-path for binding security check of DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=226930

Attachment 431211: Patch

https://bugs.webkit.org/attachment.cgi?id=431211&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 431211
  --> https://bugs.webkit.org/attachment.cgi?id=431211
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review

r=me

> Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111
> +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject*
lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption
reportingOption)

Since this is a fast path, and just a pointer comparison, should we put it
inline in the header?