[webkit-reviews] review granted: [Bug 226930] Add fast-path for binding security check of DOMWindow : [Attachment 431211] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 11 11:09:17 PDT 2021

Geoffrey Garen <ggaren at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 226930: Add fast-path for binding security check of DOMWindow

Attachment 431211: Patch


--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 431211
  --> https://bugs.webkit.org/attachment.cgi?id=431211

View in context: https://bugs.webkit.org/attachment.cgi?id=431211&action=review


> Source/WebCore/bindings/js/JSDOMBindingSecurity.cpp:111
> +bool BindingSecurity::shouldAllowAccessToDOMWindow(JSC::JSGlobalObject*
lexicalGlobalObject, JSDOMWindow& target, SecurityReportingOption

Since this is a fast path, and just a pointer comparison, should we put it
inline in the header?

More information about the webkit-reviews mailing list