[webkit-reviews] review granted: [Bug 226864] [GStreamer] media/track/audio/audio-track-mkv-vorbis-language.html and media/track/video/video-track-mkv-theora-language.html are failing : [Attachment 431152] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Diego Pino
<dpino at igalia.com>'s request for review:
Bug 226864: [GStreamer] media/track/audio/audio-track-mkv-vorbis-language.html
and media/track/video/video-track-mkv-theora-language.html are failing
https://bugs.webkit.org/show_bug.cgi?id=226864

Attachment 431152: Patch

https://bugs.webkit.org/attachment.cgi?id=431152&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 431152
  --> https://bugs.webkit.org/attachment.cgi?id=431152
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431152&action=review

> LayoutTests/media/in-band-tracks.js:58
> +	       testExpected("video." + type +"Tracks.length", values.length);
> +	       for (var i = 0; i < values.length; ++i)
> +		   testExpected("video." + type +"Tracks[" + i + "]." +
attribute, values[i]);
> +	   } else {
> +	       testExpected("video." + type +"Tracks.length",
Object.keys(values).length);
> +	       for (let id in values) {
> +		  
testExpected(`video.${type}Tracks.getTrackById('${id}').${attribute}`,
values[id]);

Nit: it is a bit odd to use both template literals and string concatenation in
this function.