[webkit-reviews] review granted: [Bug 226910] Partition CrossOriginPreflightResultCache by SessionID : [Attachment 431179] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 226910: Partition CrossOriginPreflightResultCache by SessionID
https://bugs.webkit.org/show_bug.cgi?id=226910

Attachment 431179: Patch

https://bugs.webkit.org/attachment.cgi?id=431179&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 431179
  --> https://bugs.webkit.org/attachment.cgi?id=431179
Patch


Can we get an API test for this one?
Something like:
- load a page with a sessionID, trigger a preflight and verify server has
received a preflight.
- load another page in same pool but with a different sessionID, trigger the
same prefllight and verify again the server has received the preflight.

View in context: https://bugs.webkit.org/attachment.cgi?id=431179&action=review

> Source/WebCore/loader/CrossOriginAccessControl.cpp:260
> +Expected<void, String> validatePreflightResponse(const PAL::SessionID&
sessionID, const ResourceRequest& request, const ResourceResponse& response,
StoredCredentialsPolicy storedCredentialsPolicy, const SecurityOrigin&
securityOrigin, const CrossOriginAccessControlCheckDisabler* checkDisabler)

s/const PAL::SessionID&/PAL::SessionID

> Source/WebCore/loader/CrossOriginAccessControl.h:85
> +WEBCORE_EXPORT Expected<void, String> validatePreflightResponse(const
PAL::SessionID&, const ResourceRequest&, const ResourceResponse&,
StoredCredentialsPolicy, const SecurityOrigin&, const
CrossOriginAccessControlCheckDisabler*);

Ditto here and below I guess.