[webkit-reviews] review denied: [Bug 226832] Regression(r276653) We're going to disk more often for local storage operations : [Attachment 431122] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226832: Regression(r276653) We're going to disk more often for local
storage operations
https://bugs.webkit.org/show_bug.cgi?id=226832

Attachment 431122: Patch

https://bugs.webkit.org/attachment.cgi?id=431122&action=review




--- Comment #14 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 431122
  --> https://bugs.webkit.org/attachment.cgi?id=431122
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431122&action=review

Looks good to me, but I think I spotted a bug.

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:151
> +	   for (auto& pair : *m_items) {
> +	       auto value = pair.value.isNull() ? itemBypassingCache(pair.key)
: pair.value;
> +	       items.add(pair.key, WTFMove(value));

I would call "pair" "entry" here.

> Source/WebKit/NetworkProcess/WebStorage/LocalStorageDatabase.cpp:217
> +	   if (it != m_items->end())
> +	       return { };

I think this is supposed to be ==