[webkit-reviews] review granted: [Bug 226898] Nothing is keeping navigator.xr alive during GC : [Attachment 431137] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 10 15:04:21 PDT 2021

Chris Dumez <cdumez at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 226898: Nothing is keeping navigator.xr alive during GC

Attachment 431137: Patch


--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 431137
  --> https://bugs.webkit.org/attachment.cgi?id=431137

View in context: https://bugs.webkit.org/attachment.cgi?id=431137&action=review


> Source/WebCore/ChangeLog:8
> +	   Test: webxr/gc.html

I think test Test: line usually comes after the description?

> LayoutTests/ChangeLog:15
> +2021-06-01  Sam Weinig  <weinig at apple.com>

Bad double changelog.

> LayoutTests/webxr/gc.html:5
> +<script src="../resources/js-test-pre.js"></script>

Can use js-test.js

> LayoutTests/webxr/gc.html:32
> +<script src="../resources/js-test-post.js"></script>

Not needed.

More information about the webkit-reviews mailing list