[webkit-reviews] review denied: [Bug 226849] Arm64 should zero def the result from its 32-bit sub instruction : [Attachment 431127] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 10 14:15:57 PDT 2021

Mark Lam <mark.lam at apple.com> has denied Yijia Huang <yijia_huang at apple.com>'s
request for review:
Bug 226849: Arm64 should zero def the result from its 32-bit sub instruction

Attachment 431127: Patch


--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 431127
  --> https://bugs.webkit.org/attachment.cgi?id=431127

View in context: https://bugs.webkit.org/attachment.cgi?id=431127&action=review

> Source/JavaScriptCore/ChangeLog:8
> +	   * b3/air/AirOpcode.opcodes: Zero def the destination of arm64 sub32 

This description is not accurate.  You're not defining the destination register
as zero.  Instead, you're indicating that the opcode will zero extend the
32-bit result to full register length in the destination.

Please also fix the title accordingly.	Also to provide context for this patch,
I indicate that this is in Air opcode.	For example, something like "Air ARM64
sub32 opcode should indicate that it zero-extends its result".

More information about the webkit-reviews mailing list