[webkit-reviews] review granted: [Bug 226784] [Cocoa] Remote video layer should respect video gravity when resizing : [Attachment 430910] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 226784: [Cocoa] Remote video layer should respect video gravity when
resizing
https://bugs.webkit.org/show_bug.cgi?id=226784

Attachment 430910: Patch

https://bugs.webkit.org/attachment.cgi?id=430910&action=review




--- Comment #2 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 430910
  --> https://bugs.webkit.org/attachment.cgi?id=430910
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430910&action=review

> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:90
> +- (void)
setVideoGravity:(WebCore::MediaPlayerEnums::VideoGravity)videoGravity

Nit: the spacing between (void) and setVideoGravity: is weird.

> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:95
> +- (bool) resizePreservingGravity

Ditto.