[webkit-reviews] review granted: [Bug 226844] Create SPI file for Synapse so external builds will work. : [Attachment 431001] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 226844: Create SPI file for Synapse so external builds will work.
https://bugs.webkit.org/show_bug.cgi?id=226844

Attachment 431001: Patch

https://bugs.webkit.org/attachment.cgi?id=431001&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 431001
  --> https://bugs.webkit.org/attachment.cgi?id=431001
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=431001&action=review

> Source/WebKit/Platform/spi/Cocoa/SynapseSPI.h:28
> +#if ENABLE(APP_HIGHLIGHTS)

Maybe this should be around the whole file?

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:6
> -	objectVersion = 52;
> +	objectVersion = 54;

Maybe revert this?