[webkit-reviews] review denied: [Bug 226817] [JSC] Fix incorrect register reuse in 32bit after r278568 : [Attachment 430963] Fix incorrect register reuse

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 08:03:15 PDT 2021


Caio Lima <ticaiolima at gmail.com> has denied  review:
Bug 226817: [JSC] Fix incorrect register reuse in 32bit after r278568
https://bugs.webkit.org/show_bug.cgi?id=226817

Attachment 430963: Fix incorrect register reuse

https://bugs.webkit.org/attachment.cgi?id=430963&action=review




--- Comment #6 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 430963
  --> https://bugs.webkit.org/attachment.cgi?id=430963
Fix incorrect register reuse

I retract this change. I think it wont work because we need to set `false` to
result when left.tagGPR(), right.tagGPR() are different.


More information about the webkit-reviews mailing list