[webkit-reviews] review granted: [Bug 226817] [JSC] Fix incorrect register reuse in 32bit after r278568 : [Attachment 430963] Fix incorrect register reuse

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 07:47:41 PDT 2021

Caio Lima <ticaiolima at gmail.com> has granted Caio Lima <ticaiolima at gmail.com>'s
request for review:
Bug 226817: [JSC] Fix incorrect register reuse in 32bit after r278568

Attachment 430963: Fix incorrect register reuse


--- Comment #4 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 430963
  --> https://bugs.webkit.org/attachment.cgi?id=430963
Fix incorrect register reuse

View in context: https://bugs.webkit.org/attachment.cgi?id=430963&action=review


>> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7388
>> +	GPRTemporary result(this);
> Could we try to still reuse it, but then move 0 after
`notEqual.link(&m_jit);` on line 7404? I think this would allow us to reuse
left and right payload/tag there.

Never mind, this would require another jump for Equals case. Not reusing the
tag sounds a better compromise then generating multiple branchs

More information about the webkit-reviews mailing list