[webkit-reviews] review requested: [Bug 226817] [JSC] Fix incorrect register reuse in 32bit after r278568 : [Attachment 430963] Fix incorrect register reuse

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 07:45:26 PDT 2021


Caio Lima <ticaiolima at gmail.com> has asked  for review:
Bug 226817: [JSC] Fix incorrect register reuse in 32bit after r278568
https://bugs.webkit.org/show_bug.cgi?id=226817

Attachment 430963: Fix incorrect register reuse

https://bugs.webkit.org/attachment.cgi?id=430963&action=review




--- Comment #3 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 430963
  --> https://bugs.webkit.org/attachment.cgi?id=430963
Fix incorrect register reuse

View in context: https://bugs.webkit.org/attachment.cgi?id=430963&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:7388
> +    GPRTemporary result(this);

Could we try to still reuse it, but then move 0 after `notEqual.link(&m_jit);`
on line 7404? I think this would allow us to reuse left and right payload/tag
there.


More information about the webkit-reviews mailing list