[webkit-reviews] review granted: [Bug 226469] Aspect ratio from width and height attribute is not compatible to string with invalid ends. : [Attachment 430950] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted cathiechen
<cathiechen at igalia.com>'s request for review:
Bug 226469: Aspect ratio from width and height attribute is not compatible to
string with invalid ends.
https://bugs.webkit.org/show_bug.cgi?id=226469

Attachment 430950: Patch

https://bugs.webkit.org/attachment.cgi?id=430950&action=review




--- Comment #28 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 430950
  --> https://bugs.webkit.org/attachment.cgi?id=430950
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430950&action=review

> Source/WebCore/html/parser/HTMLParserIdioms.cpp:532
> +std::optional<HTMLDimension> parseHTMLDimension(StringView dimensionString)
> +{
> +    return parseHTMLDimensionInternal(dimensionString);
> +}

This doesn't seem to add anything. Why not just have parseHTMLDimension and get
rid of the *Internal version?