[webkit-reviews] review granted: [Bug 186767] [GTK] Do not depend on resources provided by the GNOME icon theme : [Attachment 430900] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 186767: [GTK] Do not depend on resources provided by the GNOME icon theme
https://bugs.webkit.org/show_bug.cgi?id=186767

Attachment 430900: Patch

https://bugs.webkit.org/attachment.cgi?id=430900&action=review




--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 430900
  --> https://bugs.webkit.org/attachment.cgi?id=430900
Patch

The style-checker issue seems a bit like a false positive. It is possible to
workaround it by appending to the list one item at a time, for example:

  set(WebKitResources "")
  list(APPEND WebKitResources "<file
alias=\"css/gtk-theme.css\">gtk-theme.css</file>\n")
  list(APPEND WebKitResources "<file
alias=\"images/missingImage\">missingImage.png</file>\n")
  list(APPEND WebKitResources "<file
alias=\"images/missingImage at 2x\">missingImage at 2x.png</file>\n")
  ...

We can either land manually to go around the false positive, or if you feel
like
reworking this a bit as suggested to avoid the style checker complaints, then
it's
fine to use the commit-queue :)