[webkit-reviews] review granted: [Bug 186767] [GTK] Do not depend on resources provided by the GNOME icon theme : [Attachment 430900] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 9 01:18:10 PDT 2021

Adrian Perez <aperez at igalia.com> has granted Diego Pino <dpino at igalia.com>'s
request for review:
Bug 186767: [GTK] Do not depend on resources provided by the GNOME icon theme

Attachment 430900: Patch


--- Comment #6 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 430900
  --> https://bugs.webkit.org/attachment.cgi?id=430900

The style-checker issue seems a bit like a false positive. It is possible to
workaround it by appending to the list one item at a time, for example:

  set(WebKitResources "")
  list(APPEND WebKitResources "<file
  list(APPEND WebKitResources "<file
  list(APPEND WebKitResources "<file
alias=\"images/missingImage at 2x\">missingImage at 2x.png</file>\n")

We can either land manually to go around the false positive, or if you feel
reworking this a bit as suggested to avoid the style checker complaints, then
fine to use the commit-queue :)

More information about the webkit-reviews mailing list