[webkit-reviews] review denied: [Bug 226758] AX: TestWebKitAPI.WebKit.AccessibilityReduceMotion failing on iOS : [Attachment 430816] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 18:51:59 PDT 2021


Alex Christensen <achristensen at apple.com> has denied chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 226758: AX: TestWebKitAPI.WebKit.AccessibilityReduceMotion failing on iOS
https://bugs.webkit.org/show_bug.cgi?id=226758

Attachment 430816: patch

https://bugs.webkit.org/attachment.cgi?id=430816&action=review




--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 430816
  --> https://bugs.webkit.org/attachment.cgi?id=430816
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430816&action=review

> Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:1146
> +#if PLATFORM(IOS_FAMILY)

This should probably be wrapped by a !HAVE(UPDATE_WEB_ACCESSIBILITY_SETTINGS)
so we know when we can remove it.  Define
HAVE_UPDATE_WEB_ACCESSIBILITY_SETTINGS in PlatformHave.h


More information about the webkit-reviews mailing list