[webkit-reviews] review granted: [Bug 226748] Drop legacy EventLoopEventQueue class : [Attachment 430869] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 18:19:51 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226748: Drop legacy EventLoopEventQueue class

Attachment 430869: Patch


--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 430869
  --> https://bugs.webkit.org/attachment.cgi?id=430869

View in context: https://bugs.webkit.org/attachment.cgi?id=430869&action=review

> Source/WebCore/bindings/js/JSTextTrackCueCustom.cpp:48
> -	       *reason = "TextTrackCue is firing event listeners";
> +	       *reason = "ActiveDOMObject with pending activity";

Why is it better to have this message be vague?

Can we share this constant string "ActiveDOMObject with pending activity" with
uses elsewhere?

> Source/WebCore/html/track/DataCue.cpp:75
> +    dataCue->suspendIfNeeded();

A little frustrating to have to add so much boilerplate with all these calls.

More information about the webkit-reviews mailing list