[webkit-reviews] review granted: [Bug 226738] [iOS] Sync Accessibility preferences : [Attachment 430873] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 226738: [iOS] Sync Accessibility preferences
https://bugs.webkit.org/show_bug.cgi?id=226738

Attachment 430873: Patch

https://bugs.webkit.org/attachment.cgi?id=430873&action=review




--- Comment #6 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 430873
  --> https://bugs.webkit.org/attachment.cgi?id=430873
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430873&action=review

This looks like a good change. Should we use this as the basis to handle
Caption preferences, too?

> Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:586
> +    auto* pool = reinterpret_cast<WebProcessPool*>(observer);

Can observer ever be null? Perhaps we should ASSERT it? Perhaps we should test
for null before calling through it?