[webkit-reviews] review granted: [Bug 184256] CSSOM test for serializing counter() fails : [Attachment 430830] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 10:29:18 PDT 2021


Sam Weinig <sam at webkit.org> has granted Rob Buis <rbuis at igalia.com>'s request
for review:
Bug 184256: CSSOM test for serializing counter() fails
https://bugs.webkit.org/show_bug.cgi?id=184256

Attachment 430830: Patch

https://bugs.webkit.org/attachment.cgi?id=430830&action=review




--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 430830
  --> https://bugs.webkit.org/attachment.cgi?id=430830
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430830&action=review

> Source/WebCore/css/CSSPrimitiveValue.cpp:1085
> +	   if (listStyle == "decimal")
> +	       listStyle = emptyString();
>	   result.append(listStyle.isEmpty() ? "" : ", ", listStyle, ')');

This seems like it would be a bit cleaner as:

if (!(listStyle.empty() || listStyle == "decimal"))
    result.append(", ", listStyle);
result.append(')');

(or something like that).


More information about the webkit-reviews mailing list