[webkit-reviews] review granted: [Bug 226768] Move some hand rolled CSSProperty predicates to be generated based on new CSSProperties.json properties : [Attachment 430840] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 8 07:57:18 PDT 2021


Antti Koivisto <koivisto at iki.fi> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 226768: Move some hand rolled CSSProperty predicates to be generated based
on new CSSProperties.json properties
https://bugs.webkit.org/show_bug.cgi?id=226768

Attachment 430840: Patch

https://bugs.webkit.org/attachment.cgi?id=430840&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 430840
  --> https://bugs.webkit.org/attachment.cgi?id=430840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430840&action=review

> Source/WebCore/css/CSSProperties.json:101
> +	   "CSSProperty::isDescriptorOnly().",

Wonder if should make these standalone functions...


More information about the webkit-reviews mailing list