[webkit-reviews] review requested: [Bug 197002] Defer rendering in pinch to zoom : [Attachment 430823] Patch

[bugzilla-daemon at webkit.org]

Alexander Mikhaylenko <alexm at gnome.org> has asked  for review:
Bug 197002: Defer rendering in pinch to zoom
https://bugs.webkit.org/show_bug.cgi?id=197002

Attachment 430823: Patch

https://bugs.webkit.org/attachment.cgi?id=430823&action=review




--- Comment #15 from Alexander Mikhaylenko <alexm at gnome.org> ---
Created attachment 430823

  --> https://bugs.webkit.org/attachment.cgi?id=430823&action=review

Patch

Patch.

Some questions:

1. The non-AC mode zooming is still slow, I wonder if we should switch to AC
mode with ondemand when trying to zoom?

2. We always pass the same flags to flushPendingLayerChanges() with the same
condition.
   Maybe it should be a boolean/enum parameter similarly to the `enum class
UpdateRenderingType { Normal, TransientZoom }` in
`TiledCoreAnimationDrawingArea`?

3. We currently don't handle AC mode changes during the gesture, and honestly I
don't particularly want to go into that rabbit hole. IIUC if we go with 1., it
doesn't matter?