[webkit-reviews] review granted: [Bug 226351] Add copy of std::span so that we can use it pre-moving to c++20 : [Attachment 430686] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 226351: Add copy of std::span so that we can use it pre-moving to c++20
https://bugs.webkit.org/show_bug.cgi?id=226351

Attachment 430686: Patch

https://bugs.webkit.org/attachment.cgi?id=430686&action=review




--- Comment #16 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 430686
  --> https://bugs.webkit.org/attachment.cgi?id=430686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430686&action=review

std::expected has not been standardized but std::span has.  That's the
difference between this and WTF::Expected.

Do we want to introduce a use of this as we add it, such as the one I suggested
in https://bugs.webkit.org/show_bug.cgi?id=225988 ?

> Source/WTF/wtf/Span.h:3
> +//	 (See accompanying file ../../LICENSE_1_0-Boost.txt or copy at

We should probably change this to just ../LICENSE_1_0-Boost.txt