[webkit-reviews] review granted: [Bug 225893] Adopt SecTrustGetCertificateAtIndex replacement where available : [Attachment 428886] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 18:38:44 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 225893: Adopt SecTrustGetCertificateAtIndex replacement where available
https://bugs.webkit.org/show_bug.cgi?id=225893

Attachment 428886: Patch

https://bugs.webkit.org/attachment.cgi?id=428886&action=review




--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 428886
  --> https://bugs.webkit.org/attachment.cgi?id=428886
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428886&action=review

> Source/WebCore/platform/network/cocoa/CertificateInfoCocoa.mm:45
> +	       RetainPtr<CFStringRef> summary =
adoptCF(SecCertificateCopySubjectSummary(checked_cf_cast<SecCertificateRef>(CFA
rrayGetValueAtIndex(chain.get(), i))));

Could use auto


More information about the webkit-reviews mailing list