[webkit-reviews] review granted: [Bug 226216] REGRESSION (r272201): iPad render flashing on load : [Attachment 430759] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 11:59:11 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 226216: REGRESSION (r272201): iPad render flashing on load
https://bugs.webkit.org/show_bug.cgi?id=226216

Attachment 430759: Patch

https://bugs.webkit.org/attachment.cgi?id=430759&action=review




--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 430759
  --> https://bugs.webkit.org/attachment.cgi?id=430759
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430759&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:714
> +	   if ((animatedPropertyIsTransformOrRelated(animationGroup.m_property)
> +	       || animationGroup.m_property == AnimatedPropertyOpacity
> +	       || animationGroup.m_property == AnimatedPropertyBackgroundColor
> +	       || animationGroup.m_property == AnimatedPropertyFilter))

I wonder why we check the types here. Can't we just move all animations?


More information about the webkit-reviews mailing list