[webkit-reviews] review granted: [Bug 226707] Windows Python 2.7 fails to install tblib-1.7.0 due to "TypeError: environment can only contain strings" : [Attachment 430712] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 226707: Windows Python 2.7 fails to install tblib-1.7.0 due to "TypeError:
environment can only contain strings"
https://bugs.webkit.org/show_bug.cgi?id=226707

Attachment 430712: Patch

https://bugs.webkit.org/attachment.cgi?id=430712&action=review




--- Comment #5 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 430712
  --> https://bugs.webkit.org/attachment.cgi?id=430712
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430712&action=review

>>> Tools/ChangeLog:9
>>> +	     unicode strings. WinPort.setup_crash_log_saving modifies
>> 
>> Does WinCairo port need to use Python 2?
> 
> Yes. We didn't finish Python 3 migration yet. We are working on it to remove
Python 2 support.

And for what it's worth, Apple's ports weren't ready for Python 3.8 until late
last week