[webkit-reviews] review granted: [Bug 226730] Convert WebCore::SnapshotOptions into an enum class : [Attachment 430749] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 226730: Convert WebCore::SnapshotOptions into an enum class
https://bugs.webkit.org/show_bug.cgi?id=226730

Attachment 430749: Patch

https://bugs.webkit.org/attachment.cgi?id=430749&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 430749
  --> https://bugs.webkit.org/attachment.cgi?id=430749
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430749&action=review

r=mews

> Source/WebCore/page/FrameSnapshotting.h:57
> +    OptionSet<SnapshotFlags> flags = { };

Nit - you don't need the `= { }` here.

> Source/WebCore/page/FrameSnapshotting.h:59
> +    std::optional<PixelFormat> pixelFormat = std::nullopt;
> +    std::optional<DestinationColorSpace> colorSpace = std::nullopt;

Ditto (don't need the `= std::nullopt`).