[webkit-reviews] review granted: [Bug 226704] [Cocoa] Find-in-page should match text inside image overlays : [Attachment 430709] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 7 00:15:32 PDT 2021

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 226704: [Cocoa] Find-in-page should match text inside image overlays

Attachment 430709: Patch


--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 430709
  --> https://bugs.webkit.org/attachment.cgi?id=430709

View in context: https://bugs.webkit.org/attachment.cgi?id=430709&action=review

> Source/WebKit/WebProcess/WebPage/FindController.cpp:379
> +	   textIndicatorOptions.add({ TextIndicatorOption::PaintAllContent,
TextIndicatorOption::PaintBackgrounds });

I wonder (separately) if we can infer some of these options in TI and remove
some complexity from the clients. Like, give it more reasonable/intelligent
defaults and delete some of the TextIndicatorOption values. Would need a
careful pass over all the clients, though.

More information about the webkit-reviews mailing list