[webkit-reviews] review granted: [Bug 226694] Handle custom identifiers and strings separately, so we can quote strings correctly consistently : [Attachment 430678] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Darin Adler <darin at apple.com>'s request
for review:
Bug 226694: Handle custom identifiers and strings separately, so we can quote
strings correctly consistently
https://bugs.webkit.org/show_bug.cgi?id=226694

Attachment 430678: Patch

https://bugs.webkit.org/attachment.cgi?id=430678&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 430678
  --> https://bugs.webkit.org/attachment.cgi?id=430678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430678&action=review

> Source/WebCore/animation/CSSAnimation.cpp:51
> -    , m_animationName(backingAnimation.name())
> +    , m_animationName(backingAnimation.name().string)

In the future we should see if m_animationName is necessary given the base
class holds onto the backingAnimation and could pull the string from there.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:3426
> +		   for (size_t i = 0; i < t->size(); ++i) {

Would probably be a good idea for AnimationList to have an animations()
function that return an IteratorRange<> (or just the underlying Vector) at some
point to avoid this.

> Source/WebCore/css/CSSUnits.h:71
> +    CustomIdent,

Daring, I like it!