[webkit-reviews] review denied: [Bug 226668] Weak external symbols found in WebKit.framework with Release+Coverage configuration : [Attachment 430629] Patch v1

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 226668: Weak external symbols found in WebKit.framework with
Release+Coverage configuration
https://bugs.webkit.org/show_bug.cgi?id=226668

Attachment 430629: Patch v1

https://bugs.webkit.org/attachment.cgi?id=430629&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 430629
  --> https://bugs.webkit.org/attachment.cgi?id=430629
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=430629&action=review

> Source/WebKit/ChangeLog:3
> +	   Weak external symbols found in WebKit.framework with
Release+Coverage configuration

I'm happy to see activity around coverage.

> Source/WebKit/Configurations/WebKit.unexp:8
>
+__ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_
13basic_istreamIcS2_EE

I wonder if these are needed any more.	I'm not sure what use of
std::stringstream we have in WebKit.  Maybe we used to.  I can't imagine we are
re-exporting its use from ANGLE

> Source/WebKit/Configurations/WebKit.unexp:20
> +# Methods from std::__1::function<void (WebCore::PolicyAction)> class.

These shouldn't be needed any more because we use WTF::Function for that.

> Source/WebKit/Configurations/WebKit.unexp:33
> +# Soft-linked functions in source files.  Most probably have

These should probably instead be moved to a TCCSoftLink.{h, cpp}