[webkit-reviews] review granted: [Bug 226574] REGRESSION (r276882): custom properties not available on host on initial paint : [Attachment 430581] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 10:38:15 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 226574: REGRESSION (r276882): custom properties not available on host on
initial paint
https://bugs.webkit.org/show_bug.cgi?id=226574

Attachment 430581: patch

https://bugs.webkit.org/attachment.cgi?id=430581&action=review




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 430581
  --> https://bugs.webkit.org/attachment.cgi?id=430581
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430581&action=review

> Source/WebCore/style/StyleInvalidator.cpp:393
> +	   if (!resolver)
> +	       return true;

Would it be simpler to do the !resolver check and invalidations up-front?


More information about the webkit-reviews mailing list