[webkit-reviews] review granted: [Bug 226593] Fix tests that fail under executable allocation fuzzing : [Attachment 430489] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 14:35:47 PDT 2021


Mark Lam <mark.lam at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 226593: Fix tests that fail under executable allocation fuzzing
https://bugs.webkit.org/show_bug.cgi?id=226593

Attachment 430489: Patch

https://bugs.webkit.org/attachment.cgi?id=430489&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 430489
  --> https://bugs.webkit.org/attachment.cgi?id=430489
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430489&action=review

r=me

> JSTests/stress/bit-op-with-object-returning-int32.js:12
> +// This can fail if we are executable allocation fuzzing.

I think this is better phrased as "fuzzing executable allocation" instead.

> JSTests/stress/bitwise-not-fixup-rules.js:13
> +// This can fail when we executable allocation fuzz.

Ditto.


More information about the webkit-reviews mailing list