[webkit-reviews] review granted: [Bug 226595] [Hardening] Stop storing raw pointers inside WebIDBServer::m_connections : [Attachment 430495] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 3 13:42:38 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226595: [Hardening] Stop storing raw pointers inside
WebIDBServer::m_connections
https://bugs.webkit.org/show_bug.cgi?id=226595

Attachment 430495: Patch

https://bugs.webkit.org/attachment.cgi?id=430495&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 430495
  --> https://bugs.webkit.org/attachment.cgi?id=430495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430495&action=review

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.h:106
> +    WeakHashSet<IPC::Connection> m_connections; // Only used on the main
thread.

It's unfortunate that we can't assert this.


More information about the webkit-reviews mailing list