[webkit-reviews] review granted: [Bug 226589] Make WebIDBServer use WorkQueue instead of Thread : [Attachment 430480] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 226589: Make WebIDBServer use WorkQueue instead of Thread
https://bugs.webkit.org/show_bug.cgi?id=226589

Attachment 430480: Patch

https://bugs.webkit.org/attachment.cgi?id=430480&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 430480
  --> https://bugs.webkit.org/attachment.cgi?id=430480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430480&action=review

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:67
> +	   auto origins = m_server->getOrigins();

Why?

> Source/WebKit/NetworkProcess/IndexedDB/WebIDBServer.cpp:-394
> -    tryClose();

Why don't we call this anymore? This is the kind of thing function-level
changelogs are for.