[webkit-reviews] review granted: [Bug 226588] [macOS] Image extraction preview panel should automatically close when the web view is unparented : [Attachment 430486] Handle WP termination as well

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 226588: [macOS] Image extraction preview panel should automatically close
when the web view is unparented
https://bugs.webkit.org/show_bug.cgi?id=226588

Attachment 430486: Handle WP termination as well

https://bugs.webkit.org/attachment.cgi?id=430486&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 430486
  --> https://bugs.webkit.org/attachment.cgi?id=430486
Handle WP termination as well

View in context: https://bugs.webkit.org/attachment.cgi?id=430486&action=review

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:2408
> +	   m_page->closeSharedPreviewPanelIfNecessary();

maybe stick this right next to dismissContentRelativeChildWindowsWithAnimation
above?