[webkit-reviews] review granted: [Bug 226572] [css-scroll-snap] Scroll snap offsets are interpreted as scroll positions in ScrollableArea : [Attachment 430462] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 3 10:18:47 PDT 2021
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 226572: [css-scroll-snap] Scroll snap offsets are interpreted as scroll
positions in ScrollableArea
https://bugs.webkit.org/show_bug.cgi?id=226572
Attachment 430462: Patch
https://bugs.webkit.org/attachment.cgi?id=430462&action=review
--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 430462
--> https://bugs.webkit.org/attachment.cgi?id=430462
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=430462&action=review
Please check the test failures.
> Source/WebCore/platform/ScrollableArea.cpp:516
> +IntPoint ScrollableArea::nearestActiveSnapPoint(const IntPoint&
currentOffset)
Maybe we should rename this nearestActiveSnapPointForOffset(). The argument
should be a ScrollOffset.
More information about the webkit-reviews
mailing list