[webkit-reviews] review granted: [Bug 226564] [WebXR] Supply an IOSurface in SimulatedXRDevice : [Attachment 430431] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 226564: [WebXR] Supply an IOSurface in SimulatedXRDevice
https://bugs.webkit.org/show_bug.cgi?id=226564

Attachment 430431: Patch

https://bugs.webkit.org/attachment.cgi?id=430431&action=review




--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 430431
  --> https://bugs.webkit.org/attachment.cgi?id=430431
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430431&action=review

> Source/WebCore/Modules/webxr/WebXROpaqueFramebuffer.cpp:119
> +    ASSERT(data.surface);

Maybe consider making surface a UniqueRef?

> Source/WebCore/testing/WebFakeXRDevice.cpp:154
> +	   auto surface =
IOSurface::create(recommendedResolution(PlatformXR::SessionMode::ImmersiveVr),
DestinationColorSpace::SRGB());
> +	   data.layers.add(layer.key, FrameData::LayerData { .surface =
WTFMove(surface) });

I would do this in one line.