[webkit-reviews] review granted: [Bug 226327] [WPE] position:sticky content is not correctly offset on async scrolled overflow layers with an RTL vertical scrollbar : [Attachment 430453] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Lord <clord at igalia.com>'s
request for review:
Bug 226327: [WPE] position:sticky content is not correctly offset on async
scrolled overflow layers with an RTL vertical scrollbar
https://bugs.webkit.org/show_bug.cgi?id=226327

Attachment 430453: Patch

https://bugs.webkit.org/attachment.cgi?id=430453&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 430453
  --> https://bugs.webkit.org/attachment.cgi?id=430453
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430453&action=review

> Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm:80
> +	      
constrainingRect.move(overflowScrollingNode.scrollDeltaSinceLastCommit());

Seems like we should have operator+ for these types so we could do this as
expression rather than a “set to wrong value and then fix with a function
call”.