[webkit-reviews] review granted: [Bug 226518] Incorrect text selection when crossing flex item boundary : [Attachment 430433] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 2 21:13:45 PDT 2021


Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 226518: Incorrect text selection when crossing flex item boundary
https://bugs.webkit.org/show_bug.cgi?id=226518

Attachment 430433: Patch

https://bugs.webkit.org/attachment.cgi?id=430433&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 430433
  --> https://bugs.webkit.org/attachment.cgi?id=430433
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430433&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2188
> +    if (isTable() || isFlexibleBoxIncludingDeprecated() || isRenderGrid())

Should you add grid and deprecated flex box tests?


More information about the webkit-reviews mailing list