[webkit-reviews] review granted: [Bug 226266] Add LLInt fast path for less, lesseq, greater and greatereq : [Attachment 430427] Patch

[bugzilla-daemon at webkit.org]

Tadeu Zagallo <tzagallo at apple.com> has granted Mikhail R. Gadelha
<mikhail at igalia.com>'s request for review:
Bug 226266: Add LLInt fast path for less, lesseq, greater and greatereq
https://bugs.webkit.org/show_bug.cgi?id=226266

Attachment 430427: Patch

https://bugs.webkit.org/attachment.cgi?id=430427&action=review




--- Comment #8 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 430427
  --> https://bugs.webkit.org/attachment.cgi?id=430427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430427&action=review

> Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:2003
> +	   ci2ds t1, ft0

nit: no reason to convert t1 to a float before branching.

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:2194
> +	   ci2ds t0, ft0

same nit here. I saw we do this in other places, so it's up to you if you want
to move it.