[webkit-reviews] review granted: [Bug 226543] Port media code to the HTML event loop : [Attachment 430410] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 2 16:51:52 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 226543: Port media code to the HTML event loop
https://bugs.webkit.org/show_bug.cgi?id=226543

Attachment 430410: Patch

https://bugs.webkit.org/attachment.cgi?id=430410&action=review




--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 430410
  --> https://bugs.webkit.org/attachment.cgi?id=430410
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=430410&action=review

> Source/WebCore/platform/DeferrableTask.h:109
> +	  
scriptExecutionContext()->eventLoop().queueTask(TaskSource::MediaElement,
[weakThis = makeWeakPtr(*this), task = WTFMove(task)] {

Not in this patch but we should add the capability to cancel a task we
scheduled in the event loop.


More information about the webkit-reviews mailing list